On Thu, Feb 2, 2017 at 7:47 PM, Christoph Hellwig <hch@xxxxxx> wrote: > On Thu, Feb 02, 2017 at 09:45:47AM -0800, Darrick J. Wong wrote: >> On Thu, Feb 02, 2017 at 05:24:56PM +0100, Christoph Hellwig wrote: >> > We're changing both metadata and data, so we need to update the >> > timestamps. This follows existing btrfs behavior. >> >> /me wonders, should the mtime change if we're deduping? We're >> definitely changing metadata, but we shouldn't be making any >> user-visible changes to the file data. > > Good point - we're hitting this from the dedup path as well. > I think we should not be updating mtime for dedupe. Since CAP_ADMIN is allowed to dedup to an O_RDONLY dest updating mtime would be even creepier. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
