Re: [PATCH 2/7] xfs: fail _dir_open when readahead fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There is an xfs missing in the subject, I think..

On Mon, Jan 30, 2017 at 04:23:16PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> When we open a directory, we try to readahead block 0 of the directory
> on the assumption that we're going to need it soon.  If the bmbt is
> corrupt, the directory will never be usable and the readahead fails
> immediately, so we might as well prevent the directory from being opened
> at all.  This prevents a subsequent read or modify operation from
> hitting it and taking the fs offline.

I think this looks fine, but the patch description is a bit odd -
we don't actually check for failures for the actual read-ahead, just
for the block mapping, which I guess is what you need anyway.

So with a slight update to the patch descriptions:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux