On Thu, Dec 15, 2016 at 09:55:34AM +0100, Christoph Hellwig wrote: > On Wed, Dec 14, 2016 at 04:51:58PM -0500, Brian Foster wrote: > > On Wed, Dec 14, 2016 at 08:38:02PM +0100, Christoph Hellwig wrote: > > > On Wed, Dec 14, 2016 at 01:30:18PM -0500, Brian Foster wrote: > > > > > /* do we have enough contiguous free space for the allocation? */ > > > > > + alloc_len = args->minlen + (args->alignment - 1)+ args->minalignslop; > > > > > > > > Whitespace nit, missing space: ^ > > > > > > > > Also, is the addition of braces intentional? I believe it is possible > > > > for args->alignment == 0. > > > > > > It's mostly for explaining the - 1 to the reader as it took me a while > > > to figure out what it was for. > > > > Oh, care to elaborate? :) > > the alignment is the boundary we want to align to, so we'll have to add > alignment - 1 at max to achive it. Gotcha, so perhaps we should check that alignment != 0? Brian > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
