On Wed, Dec 14, 2016 at 08:38:02PM +0100, Christoph Hellwig wrote: > On Wed, Dec 14, 2016 at 01:30:18PM -0500, Brian Foster wrote: > > > /* do we have enough contiguous free space for the allocation? */ > > > + alloc_len = args->minlen + (args->alignment - 1)+ args->minalignslop; > > > > Whitespace nit, missing space: ^ > > > > Also, is the addition of braces intentional? I believe it is possible > > for args->alignment == 0. > > It's mostly for explaining the - 1 to the reader as it took me a while > to figure out what it was for. Oh, care to elaborate? :) Brian -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html