> +xfs_start_cksum_safe(char *buffer, size_t length, unsigned long cksum_offset) > +xfs_start_cksum_update(char *buffer, size_t length, unsigned long cksum_offset) What about turning the first argument into a void * for both so that we can avoid all the pointless casts? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html