> --- a/fs/xfs/xfs_stats.h > +++ b/fs/xfs/xfs_stats.h > @@ -21,10 +21,30 @@ > > #include <linux/percpu.h> > > +enum { > + __XBTS_lookup = 0, Add a comment on top of the enum to explain these are the offsets into each btree type? > +#define XFS_STATS_CALC_INDEX(member) \ > + (offsetof(struct __xfsstats, member) / (int)sizeof(__uint32_t)) what's that int cast for? Except for these nitpicks this looks great: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html