Re: [PATCH] libxfs: clean up _calc_dquots_per_chunk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/16 6:36 PM, Darrick J. Wong wrote:
> The function xfs_calc_dquots_per_chunk takes a parameter in units
> of basic blocks.  The kernel seems to get the units wrong, but
> userspace got 'fixed' by commenting out the unnecessary conversion.
> Fix both.
> 
> (This is the xfsprogs patch.)
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

ok that's a cleanup ;)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  libxfs/xfs_dquot_buf.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libxfs/xfs_dquot_buf.c b/libxfs/xfs_dquot_buf.c
> index 433abe4..aae8854 100644
> --- a/libxfs/xfs_dquot_buf.c
> +++ b/libxfs/xfs_dquot_buf.c
> @@ -200,7 +200,6 @@ xfs_dquot_buf_verify_crc(
>  		ndquots = mp->m_quotainfo->qi_dqperchunk;
>  	else
>  		ndquots = xfs_calc_dquots_per_chunk(bp->b_length);
> -//					XFS_BB_TO_FSB(mp, bp->b_length));
>  
>  	for (i = 0; i < ndquots; i++, d++) {
>  		if (!xfs_verify_cksum((char *)d, sizeof(struct xfs_dqblk),
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux