Well it's not a cleanup - it's fix ;)
On 10/18/16 6:35 PM, Darrick J. Wong wrote:
> The function xfs_calc_dquots_per_chunk takes a parameter in units
> of basic blocks. The kernel seems to get the units wrong, but
> userspace got 'fixed' by commenting out the unnecessary conversion.
> Fix both.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> fs/xfs/libxfs/xfs_dquot_buf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_dquot_buf.c b/fs/xfs/libxfs/xfs_dquot_buf.c
> index 3cc3cf7..ac9a003 100644
> --- a/fs/xfs/libxfs/xfs_dquot_buf.c
> +++ b/fs/xfs/libxfs/xfs_dquot_buf.c
> @@ -191,8 +191,7 @@ xfs_dquot_buf_verify_crc(
> if (mp->m_quotainfo)
> ndquots = mp->m_quotainfo->qi_dqperchunk;
> else
> - ndquots = xfs_calc_dquots_per_chunk(
> - XFS_BB_TO_FSB(mp, bp->b_length));
> + ndquots = xfs_calc_dquots_per_chunk(bp->b_length);
>
> for (i = 0; i < ndquots; i++, d++) {
> if (!xfs_verify_cksum((char *)d, sizeof(struct xfs_dqblk),
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
