On Mon, Oct 17, 2016 at 02:29:33PM -0700, Darrick J. Wong wrote:
> > + bs = inode->i_sb->s_blocksize;
> > + inode_dio_wait(inode);
> > +
> > + rounding = max_t(xfs_off_t, bs, PAGE_SIZE);
> > + ioffset = round_down(offset, rounding);
> > + iendoffset = round_up(offset + len, rounding) - 1;
> > + ret = filemap_write_and_wait_range(inode->i_mapping, ioffset,
> > + iendoffset);
> > + return ret;
> > +}
>
> This seems like a file action not specific to reflink.
But it's only used by the reflink code :)
That being said given that filemap_write_and_wait_range operates
on pages there is no need for the rounding anyway, and we could
just replace it with open coded calls to inode_dio_wait and
filemap_write_and_wait_range. Maybe I should do that before
this patch so we don't have to bother moving it.
> > +xfs_file_share_range(
>
> xfs_reflink_share_file_range() ?
>
> I'd like to maintain the convention that all reflink functions
> start with xfs_reflink_*, particularly since the xfs_file_* functions
> largely live in xfs_file.c.
Ok, fine.
> > + if (is_dedupe) {
> > + bool is_same = false;
> > +
> > + ret = xfs_compare_extents(inode_in, pos_in, inode_out, pos_out,
> > + len, &is_same);
> > + if (ret)
> > + goto out_unlock;;
>
> Double-semicolon here.
I'll fix it.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
