On Wed, Oct 12, 2016 at 10:13:08AM -0400, Brian Foster wrote: > > + /* > > + * Update the inode delalloc counter now and wait to update the > > + * sb counters as we might have to borrow some blocks for the > > + * indirect block accounting. > > + */ > > + xfs_trans_reserve_quota_nblks(NULL, ip, -((long)del->br_blockcount), 0, > > + isrt ? XFS_QMOPT_RES_RTBLKS : XFS_QMOPT_RES_REGBLKS); > > + ip->i_delayed_blks -= del->br_blockcount; > > + > > This appears to be fixed up later, but i_delayed_blks is accounted twice > as of this patch. It would be nice if we could avoid known breakage, > even if transient. Where do we account for it the second time? > > + case 0: > > + /* > > + * Deleting the middle of the extent. > > + * > > + * Distribute the original indlen reservation across the two > > + * new extents. Steal blocks from the deleted extent if > > + * necessary. Stealing blocks simply fudges the fdblocks > > + * accounting in xfs_bunmapi(). > > + */ > > + trace_xfs_bmap_pre_update(ip, *idx, state, _THIS_IP_); > > + got->br_blockcount = del->br_startoff - got->br_startoff; > > + > > + got_indlen = xfs_bmap_worst_indlen(ip, got->br_blockcount); > > + new_indlen = xfs_bmap_worst_indlen(ip, new.br_blockcount); > > Doesn't look like new.br_blockcount is set until a few lines below. Indeed. Fixed for the next resend. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
