Re: [PATCH] xfs: convert COW blocks to real blocks before unwritten extent conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 11, 2016 at 06:38:25PM +1100, Dave Chinner wrote:
> On Mon, Oct 10, 2016 at 03:06:34PM +0200, Christoph Hellwig wrote:
> > We need to splice COW blocks we've completed in xfs_end_io_direct_write
> > into the data fork before converting unwritten extents.  Otherwise
> > xfs_bmapi_write might first allocate blocks for any holes in the data
> > fork, which isn't only not needed but also harmful as it might cause
> > reserved block underruns in the transaction.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Committed and pushe dout to the for-next branch (commit
> feac470e3642e8956ac9b7f14224e6b301b9219d). If there's no more
> late-breaking, urgent fixes, then this is what I'll ask Linus to
> pull tomorrow....

Everything looks ok from here!

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux