> +/* XFS_IEXT_STATE_TO_FORK() -- Convert BMAP state flags to an inode fork. */ > +xfs_ifork_t * > +XFS_IEXT_STATE_TO_FORK( > + struct xfs_inode *ip, > + int state) > +{ > + if (state & BMAP_COWFORK) > + return ip->i_cowfp; > + else if (state & BMAP_ATTRFORK) > + return ip->i_afp; > + return &ip->i_df; > +} Would be nice to have a lower ase name for this. And while we're at it drop duplicating the function name in the top of the function comment. Othwerise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html