Re: [PATCH 24/63] xfs: when replaying bmap operations, don't let unlinked inodes get reaped

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 29, 2016 at 08:08:17PM -0700, Darrick J. Wong wrote:
> Log recovery will iget an inode to replay BUI items and iput the inode
> when it's done.  Unfortunately, the iput will see that i_nlink == 0
> and decide to truncate & free the inode, which prevents us from
> replaying subsequent BUIs.  We can't skip the BUIs because we have to
> replay all the redo items to ensure that atomic operations complete.
> 
> Since unlinked inode recovery will reap the inode anyway, we can
> safely introduce a new inode flag to indicate that an inode is in this
> 'unlinked recovery' state and should not be auto-reaped in the
> drop_inode path.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux