On Thu, Sep 29, 2016 at 01:22:20PM -0700, Christoph Hellwig wrote:
> On Thu, Sep 29, 2016 at 01:13:18PM -0700, Darrick J. Wong wrote:
> > Will run a full regression test tonight, but the test that extends a
> > reflinked file via truncate passes.
>
> Thanks. Module the few comments from today the series looks fine
> and passes testing both locally and over NFS here. I'd say everything
> else left is probably something we could fixup post merge.
Ok. I've incorporated everybody's comments into the patchset and it's
running through regression tests now. Barring any major failures, I'm
going to re-patchbomb and push another branch to github this
afternoon.
The big change will be the reintroduction of the fallocate
UNSHARE_RANGE mode flag; can you have a look at both the VFS patch and
the unshare patch to see if it passes the smell test?
Basically, we take the existing functionality:
falloc(fd, 0, ...) => fill the holes
falloc(fd, KEEP_SIZE, ...) => fill the holes, don't change file size
Add these two features:
falloc(fd, UNSHARE, ...) => fill the holes, pre-COW shared extents
falloc(fd, UNSHARE|KEEP_SIZE, ...) => fill the holes, pre-COW shared
extents, don't change file size
And prohibit this:
falloc(fd, UNSHARE|(any of punch, zero, insert, collapse), ...) =>
-EINVAL
--D
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
