Re: [PATCH 46/63] xfs: CoW shared EOF block when truncating file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 29, 2016 at 10:29:18AM -0700, Christoph Hellwig wrote:
> On Tue, Sep 27, 2016 at 07:58:32PM -0700, Darrick J. Wong wrote:
> > When shrinking a file, the VFS zeroes everything in the associated
> > page between the new EOF and the previous EOF to avoid leaking data.
> > If this block is shared we need to CoW it before the VFS does its
> > zeroing to avoid corrupting the other files.
> 
> This shouldn't be needed. Zeroing the EOF block goes through the
> iomap interface, which should handle the COW case properly.

Yep.  One more patch gone, yay! :)

Will run a full regression test tonight, but the test that extends a
reflinked file via truncate passes.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux