Hello Dan Carpenter, On Fri, Oct 02, 2015 at 01:17:55AM +0300, Dan Carpenter wrote: > Hello Alexander Aring, > > The patch a26c5fd7622d: "nl802154: add support for security layer" > from Sep 28, 2015, leads to the following static checker warning: > > net/ieee802154/nl802154.c:1535 nl802154_add_llsec_key() > warn: if statement not indented > > net/ieee802154/nl802154.c > 1530 if (nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX, > 1531 info->attrs[NL802154_ATTR_SEC_KEY], > 1532 nl802154_key_policy)) > 1533 return -EINVAL; > 1534 > 1535 if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] || > 1536 !attrs[NL802154_KEY_ATTR_BYTES]) > > Should this be a return -EINVAL? > Yes. Can you please provide a patch which based on bluetooth-next to linux-wpan mailinglist? Thanks. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
