Hello Alexander Aring, The patch a26c5fd7622d: "nl802154: add support for security layer" from Sep 28, 2015, leads to the following static checker warning: net/ieee802154/nl802154.c:1535 nl802154_add_llsec_key() warn: if statement not indented net/ieee802154/nl802154.c 1530 if (nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX, 1531 info->attrs[NL802154_ATTR_SEC_KEY], 1532 nl802154_key_policy)) 1533 return -EINVAL; 1534 1535 if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] || 1536 !attrs[NL802154_KEY_ATTR_BYTES]) Should this be a return -EINVAL? 1537 1538 if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0) 1539 return -ENOBUFS; 1540 regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
