Re: [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 02, 2014 at 12:22:01PM +0200, Alexander Aring wrote:
...
> 
> Okay, then maybe bluetooth 6lowpan need to set it to PACKET_HOST always.
> 
> Another idea would be:
> We could also set PACKET_BROADCAST if the IPv6 address is a
> multicast/broadcast addresss.
> 
> But it looks wrong, the PACKET_FOO values should be set by mac layer only.
> 
> 
> What I deteced is at [0]. There it checks if the "mac frame" was
> broadcast or multicast. I don't know when this occurs, I need to check
> this but it seems to be broken, when we always set the PACKET_HOST.
> 
> 
> 
> Simon had issues with routing when IPv6 Layer gets a skb with PACKET_HOST and
> it was PACKET_OTHERHOSTS before.
> 
> 
> Simon:
> 
> Maybe only send patch:
> 
> [PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop PACKET_OTHERHOST skbs in 6lowpan
> 
> this should fix your routing problems, but issue with [0] still exists.
> 

Another idea would be to put out the handling of setting pkt_type inside
the 6LOWPAN GENERIC branch. This is what Martin does in the lowpan_rcv
fixes... I still need some time to review his patch.

Maybe Simon add patch "[PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop
PACKET_OTHERHOST skbs in 6lowpan" this only affects the 802.15.4 branch.

Then Martin solve the lowpan_rcv issue which put out the handling of
pkt_type in lowpan_header_create function. Then you can do whatever
bluetooth need to do there and we can drop the override of set this
value to PACKET_HOST.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux