Re: ICMPv6 Redirects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 29, 2014 at 04:39:41PM +0200, Alexander Aring wrote:
> Simon,
> 
> On Mon, Sep 29, 2014 at 03:12:21PM +0100, Simon Vincent wrote:
> > 
> > On 29/09/14 14:58, Alexander Aring wrote:
> > >On Mon, Sep 29, 2014 at 02:51:51PM +0100, Simon Vincent wrote:
> > >>Sorry for the confusion. My problem is I am receiving all packets.
> > >>PACKET_OTHERHOST does not seem to be dropped. A suggestion from Varka was to
> > >>disable redirects however it now seems that this is not possible on a ipv6
> > >>interface.
> > >>
> > >>I can fix the problem by dropping PACKET_OTHERHOST in mac802154_subif_frame.
> > >The first what IPv6 does is [0].
> > >
> > >See my previous mail. Also that we should handle on 6LoWPAN packet
> > >handler function for receiving "lowpan_rcv" we should do the same,
> > >otherwise we parsing PACKET_OTHERHOST sk_buff's and drop these directly
> > >in IPv6 layer, which makes no sense.
> > >
> > >But what I see is that the current behaviour should also work.
> > >Instrument the IPv6 delivery function and be sure that the information
> > >about PACKET_OTHERHOST was not dropped.
> > I do not catch any PACKET_OTHERHOST packets in the ip6_input.c ipv6_rcv
> > function.
> > I don't think the packets get this far. Also in the ieee802154_rcv function
> > they are dropped. I will add some more debug to find where the redirects
> > come from.
> 
> I think I have it.
> 
> Remove this line [0].
> 
> This is wrong, all packets will be PACKET_HOST then.
> 
> Try and test it again, please.
> 
> - Alex
> 
> [0] http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/ieee802154/6lowpan_rtnl.c?id=f19f4f9525cf32f97341fac20ce66392e86a1b67#n527

Additional also remove the line [1]. :-) Ugly bug.

- Alex

[1] http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/6lowpan/iphc.c?id=f19f4f9525cf32f97341fac20ce66392e86a1b67#n192
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux