Search Linux Wireless

Re: [PATCH] rt2x00: Use addr_mask to catch invalid MAC addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ivo,

On Tue, Nov 27, 2012 at 4:56 PM, Ivo Van Doorn <ivdoorn@xxxxxxxxx> wrote:
> Hi,
>
>> This ensures that a user cannot accidentally set up a virtual interface
>> with a MAC address the rt2800 hw cannot handle.
>>
>> Reported-by: Petr Stetiar <ynezz@xxxxxxx>
>> Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>
>> ---
>>  drivers/net/wireless/rt2x00/rt2800lib.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
>> b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index c0441a7..7f0df12 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -5108,6 +5108,9 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev
>> *rt2x00dev)
>>                                 rt2x00_eeprom_addr(rt2x00dev,
>>                                                    EEPROM_MAC_ADDR_0));
>>
>> +       /* Only the last three bits are variable in rt2800 devices. */
>> +       rt2x00dev->hw->wiphy->addr_mask[ETH_ALEN - 1] = 0x7;
>
>
> Shouldn't this be added for rt61pci and rt73usb as well?

I'm not 100% sure if the same is true in rt61pci and rt73usb. Are they
also using an
address mask?

Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux