On Tue, 2012-11-20 at 13:57 +0200, Eliad Peller wrote: > On Tue, Nov 20, 2012 at 1:42 PM, Luciano Coelho <coelho@xxxxxx> wrote: > > On Tue, 2012-11-20 at 13:20 +0200, Eliad Peller wrote: > >> if (ret < 0) > >> - goto out; > >> + return ret; > >> > >> -out: > >> return ret; > >> } > > > > This is, of course, functionally okay, but seems like an unrelated > > change. Also, this is different than the general style we use in the > > driver (ie. use goto out in most error cases). > > > > Same thing for the other functions you added. It would be nice to be > > consistent with the existing style, at least in error paths. > > > AFAICT, a major part of the functions in the driver use the "goto out" > only when there's cleanup work to do. > this is also the convention in mac80211. > > but then again, i don't mind changing it if that's your preference. Nah, never mind. I noticed this is now different everywhere, no need to bother. -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
