On Tue, Nov 20, 2012 at 1:45 PM, Arik Nemtsov <arik@xxxxxxxxxx> wrote: > On Tue, Nov 20, 2012 at 1:20 PM, Eliad Peller <eliad@xxxxxxxxxx> wrote: >> Add some basic chanctx implementation - debug prints, >> and save the vif's channel/band/type. >> >> After that, we no longer need to handle channel change >> notifications on op_config. >> >> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> --- >> + /* update default rates according to the band */ >> + wl1271_set_band_rate(wl, wlvif); > > set_band_rate should be fixed to also set wl->basic_rate. but this can > be a separate patch.. > previously we had some manual code to set the basic_rate, which you removed. as i mentioned before, there is a huge mess in the rates handling. for sta - we set wlvif->basic_rate anyway on CHANGED_BSSID for ap - we don't use it at all, but use wl1271_tx_min_rate_get(wl, wlvif->basic_rate_set) so it's not really an issue. i think we should handle all this in a separate patch. Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
