On Tue, Nov 20, 2012 at 9:55 AM, Luciano Coelho <coelho@xxxxxx> wrote: > On Mon, 2012-11-19 at 18:39 +0200, Eliad Peller wrote: >> The supported_rates field should contain all our supported >> rates, even if the remote peer doesn't support them. >> >> (use CONF_TX_AP_ENABLED_RATES for bg rates, as the possible >> rates are the same for ap and sta) > > Maybe the macro should be renamed then? > sure. >> @@ -461,7 +462,14 @@ int wl12xx_cmd_role_start_sta(struct wl1271 *wl, struct wl12xx_vif *wlvif) >> cmd->sta.ssid_len = wlvif->ssid_len; >> memcpy(cmd->sta.ssid, wlvif->ssid, wlvif->ssid_len); >> memcpy(cmd->sta.bssid, vif->bss_conf.bssid, ETH_ALEN); >> - cmd->sta.local_rates = cpu_to_le32(wlvif->rate_set); >> + >> + supported_rates = CONF_TX_AP_ENABLED_RATES | CONF_TX_MCS_RATES | >> + wlcore_hw_sta_get_ap_rate_mask(wl, wlvif); >> + if (wlvif->p2p) >> + supported_rates &= ~CONF_TX_CCK_RATES; > > Why not do this when creating the vif (init_vif_data)? I think this kind > of code doesn't belong in the cmd function. Seem better to adjust > wlvif->rate_set. > well, this value is used only here. i don't think adding it to wl struct and initializing it in a different place is really better. however, i don't mind doing so if you insist :) Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
