On Tue, Nov 20, 2012 at 9:39 AM, Luciano Coelho <coelho@xxxxxx> wrote: > On Mon, 2012-11-19 at 18:39 +0200, Eliad Peller wrote: >> The default ps mode of the fw is auto, while the default >> ps mode of mac80211 is active (ps off). >> In order to sync them, configure active ps on association. >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> --- >> drivers/net/wireless/ti/wlcore/main.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c >> index e1f0606..0dd0ec1 100644 >> --- a/drivers/net/wireless/ti/wlcore/main.c >> +++ b/drivers/net/wireless/ti/wlcore/main.c >> @@ -2534,6 +2534,15 @@ static int wlcore_set_assoc(struct wl1271 *wl, struct wl12xx_vif *wlvif) >> ACX_KEEP_ALIVE_TPL_VALID); >> if (ret < 0) >> goto out; >> + >> + /* >> + * The default fw psm configuration is AUTO, while mac80211 default >> + * setting is off (ACTIVE), so sync the fw with the correct value. >> + */ >> + ret = wl1271_ps_set_mode(wl, wlvif, STATION_ACTIVE_MODE); >> + if (ret < 0) >> + goto out; >> + > > Does mac80211 enable PS soon after this by default? > usually yes (unless userspace disabled it, etc.). the problem is when mac80211 doesn't enable it - we won't get any CHANGED_PSM notification, and then while mac80211 considers it as active, the fw is configured (by default) to AUTO. Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
