Search Linux Wireless

Re: [PATCH v2 01/22] brcmsmac: Introduce AMPDU sessions for assembling AMPDUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/16/2012 03:12 PM, Seth Forshee wrote:
What does strike me as problematic is the locking in brcms_ops_flush().
It holds wl->lock, and the interrupt handling tries to acquire the same
lock. Doesn't this prevent both the txpktpend counts from getting
updated and any more packets being transmitted from the packet queue?

Seth


Actually, in the brcms_c_wait_for_tx_completion() the while loop does a brcms_msleep() which releases the wl->lock, does an msleep() and acquires the lock. At least that is what is currently in wireless-testing. I changed it internally to wait_for_event() mechanism, but it was not accepted as people still were seeing issues.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux