On Thu, 2012-10-25 at 12:12 -0700, Javier Cardona wrote: > >> hdr = (struct ieee80211_hdr *)rx->skb->data; > >> fc = hdr->frame_control; > >> + > >> + if (ieee80211_is_ctl(fc)) > >> + return RX_CONTINUE; > > > > Shouldn't that be "goto out"? > > If we goto out, we'll increment the rx_packets counter, which > according to sta_info.h should only count MSDUs. Ok. > > And it seems it should also incorporate the skb->len check here, rather than accessing the field before checking > > that it's present? > > ieee80211_rx_h_check() zaps all skbs with len < 16, so I don't think > it's needed, no? But the sequence control field is at offset 22, I think? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
