Johannes, On Thu, Oct 25, 2012 at 12:03 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2012-10-25 at 11:10 -0700, Javier Cardona wrote: >> Per IEEE Std. 802.11-2012, Sec 8.2.4.4.1, the sequence Control field is >> not present in control frames. We noticed this problem when processing >> Block Ack Requests. >> > > Cc stable? Sure. >> hdr = (struct ieee80211_hdr *)rx->skb->data; >> fc = hdr->frame_control; >> + >> + if (ieee80211_is_ctl(fc)) >> + return RX_CONTINUE; > > Shouldn't that be "goto out"? If we goto out, we'll increment the rx_packets counter, which according to sta_info.h should only count MSDUs. > And it seems it should also incorporate the skb->len check here, rather than accessing the field before checking > that it's present? ieee80211_rx_h_check() zaps all skbs with len < 16, so I don't think it's needed, no? Javier -- Javier Cardona cozybit Inc. http://www.cozybit.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
