On 2012-10-13 07:38, Kalle Valo wrote:
But after a more thorough review I still think that this driver should go to drivers/net/wireless. For example, it has proper endian support, it's both gcc and sparse warning free and the code is a pleasure to read(!).
Thanks for the feedback. I'm heavily inspired by the wl12xx code so I guess the style suites you :)
Here are my comments: * use ALIGN() and IS_ALIGNED() macros instead of doing it manually
Will fix.
* checkpatch complains about DOS line endings (but that might be due to mail server, not sure)
No DOS line endings here. Probably chewed somewhere along the way.
* git-am complained about whitespace damage
Will fix.
* defines inside structures is not common, kernel style is to have the defines on top of the structure definition
Hmmm. That's legacy from the FreeBSD driver. All those structs are copy-pasted from here: http://svn.freebsd.org/base/stable/9/sys/dev/usb/wlan/if_uathreg.h I would prefer to keep as close as possible to that file but if it's an issue I can certainly change that. I'll respin the patches asap. Cheers, Pontus -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
