"John W. Linville" <linville@xxxxxxxxxxxxx> writes: >> I did a really quick 5 min review of this driver and IMHO this should go >> directly to drivers/net/wireless/ (or maybe to drivers/net/wireless/ath, >> Luis?), I don't see any reason why this should go to staging. The code >> looks clean and is only 2 kLOC. But I'll review this better during the >> weekend and also run some build tests. > > I have no particular objection to that. FWIW, Pontus contacted me > and said something like "I've got this driver that sucks and needs > a lot of work, should it go to staging?" Perhaps he was being too > hard on himself? :-) Well, we are not exactly famous about giving positive feedback ;) So no wonder new people are extra cautious. But after a more thorough review I still think that this driver should go to drivers/net/wireless. For example, it has proper endian support, it's both gcc and sparse warning free and the code is a pleasure to read(!). Here are my comments: * use ALIGN() and IS_ALIGNED() macros instead of doing it manually * checkpatch complains about DOS line endings (but that might be due to mail server, not sure) * git-am complained about whitespace damage * defines inside structures is not common, kernel style is to have the defines on top of the structure definition -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
