> On Wed, 8 Aug 2012 19:20:15 +0200 > Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> wrote: > >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> >> --- > > Please see Documentation/SubmittingPatches in Linux sources. In > particular, you separated the description of the patch from its > contents. Single patch doesn't need to be send as series. The > description for the series is not a substitute for a description of > every patch. > > Also, the subject should summarize the patch. I know, it may be hard > to fit, but not impossible. > Ack. I will rewrite the mail. > When exactly would you have the problem that decrypt_error is not > unset, but should be? It's important that you show your assumptions so > that others can see if they are correct, in addition to checking the > code. Other developers are more likely to check your patch if you > show understanding of the code you have changed. > Assume hw reports a decryption error, the flag decrypt_error is set to true in ath9k_rx_accept. Since this flag is initialized to false just out of ath_rx_tasklet while cycle, all subsequent frames are marked as corrupted until ath_rx_tasklet ends. >> --- a/drivers/net/wireless/ath/ath9k/recv.c >> +++ b/drivers/net/wireless/ath/ath9k/recv.c >> @@ -1780,7 +1780,6 @@ > > That's weird, recv.c is 1273 lines long in wireless-testing.git. > > -- > Regards, > Pavel Roskin Regards Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
