Search Linux Wireless

Re: [PATCH 1/1] ath9k: decrypt_error flag issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Aug 2012 19:20:15 +0200
Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> wrote:

> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx>
> ---

Please see Documentation/SubmittingPatches in Linux sources.  In
particular, you separated the description of the patch from its
contents.  Single patch doesn't need to be send as series.  The
description for the series is not a substitute for a description of
every patch.

Also, the subject should summarize the patch.  I know, it may be hard
to fit, but not impossible.

When exactly would you have the problem that decrypt_error is not
unset, but should be?  It's important that you show your assumptions so
that others can see if they are correct, in addition to checking the
code.  Other developers are more likely to check your patch if you
show understanding of the code you have changed.

> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -1780,7 +1780,6 @@

That's weird, recv.c is 1273 lines long in wireless-testing.git.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux