On Wed, Aug 01, 2012 at 05:53:58PM +0200, Johannes Berg wrote: > On Wed, 2012-08-01 at 17:51 +0200, Arend van Spriel wrote: > > On 08/01/2012 05:38 PM, Arend van Spriel wrote: > > >> brcmsmac needs to hold cfg80211_mutex before calling freq_reg_info... > > >> > > > >> > It looks like those calls were added in mid-June. > > >> > > > > I think mid-june sounds about right. We never observed the warning when > > > changes to use regulatory infrastructure were tested/reviewed. Should > > > this precondition be mentioned in cfg80211.h? > > > > > > Gr. AvS > > > > Diving in further it seems brcmsmac can not grab the cfg80211_mutex. So > > another solution is needed. > > Yeah I was going to say -- how can it possibly access that? It seems > that in some patch the API got broken, it should be taking the lock or > whatever ... I'll leave it to Luis to sort out though :-P In other drivers freq_reg_info only seems to get used by the regulatory notifiers, which get called with the lock held. brcmsmac is wanting to know whether or not OFDM is allowed when setting the channel though, and I didn't find that information anywhere outside the regulatory information. If there's another way then calling freq_reg_info() could be avoided. Or maybe we could add an OFDM flag to the channel information? Seth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
