On 2012-07-15 4:21 AM, Manoharan, Sujith wrote: > I believe mac80211 has a per-VIF idea of queue parameters (tx_conf in struct ieee80211_sub_if_data). > And we end up overwriting the parameters of the main interface. For example, > > * Bringing up an AP interface: > > ath: phy0: Configure tx [queue/halq] [0/0], aifs: 1, cw_min: 3, cw_max: 7, txop: 47 > ath: phy0: Configure tx [queue/halq] [1/1], aifs: 1, cw_min: 7, cw_max: 15, txop: 94 > ath: phy0: Configure tx [queue/halq] [2/2], aifs: 3, cw_min: 15, cw_max: 63, txop: 0 > ath: phy0: Configure tx [queue/halq] [3/3], aifs: 7, cw_min: 15, cw_max: 1023, txop: 0 > > * Adding a new station interface (but not associated yet): > > ath: phy0: Attach a VIF of type: 2 > > ath: phy0: Configure tx [queue/halq] [0/0], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 > ath: phy0: Configure tx [queue/halq] [1/1], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 > ath: phy0: Configure tx [queue/halq] [2/2], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 > ath: phy0: Configure tx [queue/halq] [3/3], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 Yes, but ath9k only has global queue settings, not per-vif ones, so I'm not sure what can be done about the issue of overwriting queue settings. Either way, it's important for the aggregation limit to be in sync with the hardware queue TXOP limit, so I believe this patch is correct. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
