I believe mac80211 has a per-VIF idea of queue parameters (tx_conf in struct ieee80211_sub_if_data). And we end up overwriting the parameters of the main interface. For example, * Bringing up an AP interface: ath: phy0: Configure tx [queue/halq] [0/0], aifs: 1, cw_min: 3, cw_max: 7, txop: 47 ath: phy0: Configure tx [queue/halq] [1/1], aifs: 1, cw_min: 7, cw_max: 15, txop: 94 ath: phy0: Configure tx [queue/halq] [2/2], aifs: 3, cw_min: 15, cw_max: 63, txop: 0 ath: phy0: Configure tx [queue/halq] [3/3], aifs: 7, cw_min: 15, cw_max: 1023, txop: 0 * Adding a new station interface (but not associated yet): ath: phy0: Attach a VIF of type: 2 ath: phy0: Configure tx [queue/halq] [0/0], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 ath: phy0: Configure tx [queue/halq] [1/1], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 ath: phy0: Configure tx [queue/halq] [2/2], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 ath: phy0: Configure tx [queue/halq] [3/3], aifs: 2, cw_min: 31, cw_max: 1023, txop: 0 Sujith ________________________________________ From: Felix Fietkau [nbd@xxxxxxxxxxx] Sent: Saturday, July 14, 2012 3:32 PM To: Manoharan, Sujith Cc: linux-wireless@xxxxxxxxxxxxxxx; linville@xxxxxxxxxxxxx; Rodriguez, Luis Subject: Re: [PATCH v2 08/12] ath9k: fix aggregate size limit based on queue TXOP limit On 2012-07-14 8:04 AM, Sujith Manoharan wrote: > Felix Fietkau wrote: >> @@ -1384,6 +1384,7 @@ static int ath9k_conf_tx(struct ieee80211_hw *hw, >> queue, txq->axq_qnum, params->aifs, params->cw_min, >> params->cw_max, params->txop); >> >> + ath_update_max_aggr_framelen(sc, queue, qi.tqi_burstTime); >> ret = ath_txq_update(sc, txq->axq_qnum, &qi); >> if (ret) >> ath_err(common, "TXQ Update failed\n"); > > Wouldn't this break multi-interface operation ? This unconditionally > updates the aggr. limits of an existing interface when a new one is added. No, this doesn't break multi-interface. TXOP limit (like other WMM settings) can only be configured per-wiphy, so the max. aggregation lengths are per-wiphy as well. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
