On Fri, 2012-07-06 at 10:41 +0300, Arik Nemtsov wrote: > >> You mean move out ht_supported? > > > > Yeah, I think that'd make more sense? Have it in the sband directly. > > It does make more sense. But I was thinking there might be code > setting this dynamically in some drivers, so the changes would be > non-trivial. The union was sort of a compromise. Well the thing is ... it'll always stay that way if we don't fix it now. I don't think it's a huge deal to change all the drivers, though I'll admit that it might be a little tricky in some drivers. > Maybe move it out for vht_cap for now? :) Here's to hoping you fix the chips in the future instead! ;-) > > I think the function should restrict to NO_HT in case it doesn't have > > caps, otherwise it can't properly restrict. I suppose that means you > > won't be able to do HT monitoring with your device, but I can live with > > that. > > Actually the ht_supported flag is still global, so HT monitoring is > possible, just not HT40 monitoring I think. We'll fix that if the need > arises (or just boot the driver with fixed caps via a module param). Yeah I guess that's true. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
