2012/6/28 Joe Perches <joe@xxxxxxxxxxx>:
> I think it'd be better to add and use:
>
> #define bcma_bus_err(bus, fmt, ...) \
> pr_err("bus %d: " fmt, (bus)->num, ##__VA_ARGS__)
>
> #define bcma_bus_info(bus, fmt, ...) \
> pr_info("bus %d: " fmt, (bus)->num, ##__VA_ARGS__)
>
> or some other equivalent use if you're wedded
> to wanting "bcma-%d:" prefixed output.
>
> I'd rather have the prefix be something like "bcma: <bus#>: ",
> so a dmesg grep pattern can be "^bcma:" but hey, it ain't my code.
It doesn't seem to be sth common to have grep-pable "bcma:". Some examples:
pci_root PNP0A08:00: host bridge window [mem 0x000d8000-0x000dbfff]
pci 0000:00:01.0: [8086:2a41] type 1 class 0x000604
pnp 00:00: [bus 00-ff]
system 00:03: [mem 0xfed00000-0xfed003ff] has been reserved
pci_bus 0000:0a: resource 5 [io 0x0d00-0xffff]
ahci 0000:00:1f.2: version 3.0
scsi0 : ahci
scsi1 : ahci
usb 2-6: New USB device found, idVendor=054c, idProduct=0377
sky2 0000:08:00.0: Yukon-2 EC Ultra chip revision 3
iwlagn 0000:06:00.0: HW Revision ID = 0x0
My decision will be to use
bcma 0:
bcma 1:
bcma 2:
etc. That will be the most compatible solution with the rest of the kernel.
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
