2012/6/28 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Thu, 2012-06-28 at 21:44 +0200, Rafał Miłecki wrote: > >> +#define bcma_err(fmt, ...) \ >> + pr_err(KBUILD_MODNAME "-%d: " fmt, bus->num, ##__VA_ARGS__) > > both of your options seem to rely on "bus" being a variable in the > context, is that really a good idea? Yeah, I made that assumption to make calls nicer & shorter. We may need to get reference to "bus" in function or two. I saw such a solution in "radeon" gpu driver, example: value = RREG32(R600_AUDIO_STATUS_BITS); (they assume "rdev" is available in every function calling RREG32). If you believe it's ugly, I can change that. I also wonder what Joe will respond. P.S. Both patches are not signed yet and they are supposed to be RFC. Sorry for missing that in subject line. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
