________________________________________ From: Arend van Spriel [arend@xxxxxxxxxxxx] Sent: Thursday, June 28, 2012 6:23 PM To: Mahesh Palivela Cc: Johannes Berg; linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx Subject: Re: [PATCH] cfg80211/mac80211: 802.11ac changes On 06/28/2012 02:39 PM, Mahesh Palivela wrote: > ________________________________________ > From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx] > Sent: Thursday, June 28, 2012 4:37 PM > To: Mahesh Palivela > Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] cfg80211/mac80211: 802.11ac changes > >> >> + if (sband->vht_cap.vht_supported) >> + pos = ieee80211_ie_build_vht_cap(pos, &sband->vht_cap, >> + sband->vht_cap.cap); > > indentation > > [MP] sorry. I didn't get. Is it sband-> line to be moved left? But previous build_ht_cap() has similar indentation > 'sband->' should start at same column as 'pos' in the above line. Must be tabs followed by right amount of spaces (being less than 8). >> return pos - buffer; >> } >> >> @@ -1696,6 +1700,27 @@ u8 *ieee80211_ie_build_ht_cap(u8 *pos, struct ieee80211_sta_ht_cap *ht_cap, >> return pos; >> } >> >> +u8 *ieee80211_ie_build_vht_cap(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap, >> + u32 cap) > > indentation here & in ieee80211_i.h > > [MP] ditto. please explain > 'u32' should start at same column as 'u8 *pos' in the above line. Gr. AvS Thank you Arend. I will make those changes. Mahesh-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
