On Thu, Jun 28, 2012 at 12:30 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2012-06-28 at 11:37 +0300, Arik Nemtsov wrote: >> On Thu, Jun 28, 2012 at 11:17 AM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Wed, 2012-06-27 at 21:25 +0300, Arik Nemtsov wrote: >> >> Previously, a connected STA/AP could send us some AMPDUs right after >> >> recovery, without the driver knowing anything about it. >> > >> > Huh, that description doesn't make a lot of sense? The STA/AP can send >> > us AMPDUs anyway without the driver knowing anything about it since it >> > has no idea we're restarting ... >> >> Well the point is to drop them early in the Rx path. Should I change >> the description or you don't like the patch in general? > > I don't mind the patch, I just don't quite understand it still. > > The driver is receiving the AMPDUs anyway, and if it's passing them up > why do we need to drop them? Well if the de-aggregration is in HW, they won't make it as far as mac80211. So this patch is for SW de-aggregators. But come to think of it, if the de-aggregation is done in SW, I guess there's no real issue with accepting them, since mac80211 didn't really reboot. I guess we can drop the patch? It just seemed more correct to put the in_reconfig to false there. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html