On Wed, Jun 20, 2012 at 8:39 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2012-06-20 at 20:17 +0300, Goldenshtein, Victor wrote: > >> >> * @NL80211_FEATURE_DFS: Radar detection is supported in the HW/driver. >> >> + * @NL80211_FEATURE_AP_CH_SWITCH: This driver supports AP channel switch. >> > >> > what point is there in separating these flags? >> > >> >> One may support AP channel switch without DFS support, i.e. switching >> to non DFS channels. > > Oh, right, makes sense, though I'd enforce that DFS must support > chanswitch? > we already do that, hostapd can start working on DFS channels only if both flags are set. >> > >> >> + int (*ap_channel_switch)(struct wiphy *wiphy, struct net_device *dev, >> >> + u32 count, bool block_tx, >> >> + bool post_switch_block_tx, >> >> + struct ieee80211_channel *new_ch); >> > >> > If mac80211 needs a struct, why not have one here already rather than >> > all the parameters? >> > >> >> OK, it I will just require additional mac patch before current one, I >> will split the "mac80211: add ap channel switch command/event". > > Well, you'll have to move the struct definition into cfg80211 and into > this patch I think. > The STA channel switch struct (struct ieee80211_channel_switch) is defined in mac80211.h, thus I think the new struct for the ap channel switch should be also there, I will just split the mac patch into two. And, almost forgot, thanks for reviewing so many patches in one day ;-) -- Victor. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
