Search Linux Wireless

Re: [PATCH v2 5/7] nl80211/cfg80211: add ap channel switch command/event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2012 at 11:47 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2012-06-19 at 16:11 +0300, Victor Goldenshtein wrote:
>
>> @@ -565,6 +565,15 @@
>>   *   the time passed sines the beginning of the CAC is less than
>
> interestingly now I see a typo in the previous patch: "sines"?
>
>
>>   * @NL80211_FEATURE_DFS: Radar detection is supported in the HW/driver.
>> + * @NL80211_FEATURE_AP_CH_SWITCH: This driver supports AP channel switch.
>
> what point is there in separating these flags?
>

One may support AP channel switch without DFS support, i.e. switching
to non DFS channels.

>
>> +     int     (*ap_channel_switch)(struct wiphy *wiphy, struct net_device *dev,
>> +                                  u32 count, bool block_tx,
>> +                                  bool post_switch_block_tx,
>> +                                  struct ieee80211_channel *new_ch);
>
> If mac80211 needs a struct, why not have one here already rather than
> all the parameters?
>

OK, it I will just require additional mac patch before current one, I
will split the "mac80211: add ap channel switch command/event".

-- 
Thanks,
Victor.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux