Felix Fietkau wrote: > Having two similar implementations of the same thing in the code, > partially overlapping, makes the code hard to follow and hard to fix. > Also, as I pointed out, the issue of regressions creeping in because of > complex code is not theoretical, it has already happened, and I believe > it is likely to happen again unless the root cause (spaghetti code) is > fixed. > The main state machine of the new implementation is much easier to > understand and follow than the old one, and I'm confident that it'll be > much easier for us to fix bugs there. Speaking of bugs, ANI doesn't even get triggered on a system with HZ=1000 and PowerSave is enabled. The check for the power state causes it to exit early, I think. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
