On 06/14/2012 01:08 PM, Johannes Berg wrote: > On Thu, 2012-06-14 at 12:55 -0400, Will Hawkins wrote: >> >> On 06/14/2012 12:53 PM, Johannes Berg wrote: >>> On Thu, 2012-06-14 at 14:46 +0200, Nicolas Cavallari wrote: >>>> On 14/06/2012 13:24, Johannes Berg wrote: >>>>> On Thu, 2012-06-14 at 10:00 +0200, Nicolas Cavallari wrote: >>>>> >>>>>> I just have a question here : when auth frames are not delivered to >>>>>> userspace, mac80211 will respond to them, and also uses them to detect >>>>>> node reboot. If you register for auth frames, mac80211 will still send >>>>>> auth frames as soon as a new station is seen, which might be confusing >>>>>> for user space. Is that ok to do this ? Or should userspace have more >>>>>> control over how mac80211 sends auth frames ? >>>>> >>>>> Please read the code. If userspace registers for them, mac80211 will >>>>> never do anything with the frame. >>>> >>>> I didn't say the contrary. But if you read ieee80211_ibss_finish_sta(), >>>> you see that mac80211 sends auth frames to each discovered station, even >>>> if userspace want to handle auth frames. This seems strange to be able >>>> to receive and handle auth frames from userspace while mac80211 sends >>>> them behind userspace's back. >>> >>> Oops, sorry, yes. I forgot all about that code! >>> >>> I suppose we'd have to check whether userspace is handling >>> authentication? >> >> Could use the control_port flag to check for that condition? > > Not really, that's not necessarily the same thing -- I think we might > want to also allow to offload open auth to userspace. > > I think it wouldn't be difficult to notify mac80211 about frame > registrations so it can keep track for this purpose? > > johannes I am happy to code something like this up. I've already taken a look at it and don't think it will be too big of a problem. I am going to be AFK until Monday so I won't get to it until then. I hope that's not a problem. Will > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
