On 06/11/2012 08:43 PM, John W. Linville wrote: > On Sun, Jun 10, 2012 at 06:57:29AM +0200, Arend van Spriel wrote: >> On 06/10/2012 04:13 AM, Gábor Stefanik wrote: >>> On Sat, Jun 9, 2012 at 10:51 PM, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: >>>> The checkdied functionality provides useful information for analyzing >>>> firmware crashes. By exposing this information to a debugfs file users >>>> can easily provide its content in bug reports. The functionality is >>>> available only when CONFIG_BRCMDBG is selected. >>>> >>>> Reviewed-by: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx> >>>> Reviewed-by: Franky (Zhenhui) Lin <frankyl@xxxxxxxxxxxx> >>>> Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> >>>> --- >>>> + /* allocate buffer for console data */ >>>> + if (console_size <= CONSOLE_BUFFER_MAX) >>>> + conbuf = kzalloc(console_size+1, GFP_ATOMIC); >>>> + >>>> + if (!conbuf) >>>> + return -ENOMEM; >> >> Probably would be better to use vmalloc() here or at least use >> GFP_KERNEL here. >> >> John, any recommendations? > > vmalloc seems reasonable... > Thanks, John Can you take the first four patches? I will make a v2 for this one. Let me know if that is ok with you. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
