Hello Johannes, On Sat, Jun 9, 2012 at 1:50 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2012-06-07 at 19:21 -0700, Ashok Nagarajan wrote: >> Currently mesh uses mandatory rates as default basic rates. This patch >> introduces basic rates to be configured at the time of joining mesh. > >> + if (!sdata->vif.bss_conf.basic_rates) >> + sdata->vif.bss_conf.basic_rates = >> + ieee80211_mandatory_rates(sdata, band); > > I think this default should come from cfg80211 instead, there's little > point in imposing this calculation on all drivers that want to use mesh. > This default initialization uses the mac80211 utility function which will not be accessible from cfg80211. Could you please explain what is the advantage/purpose of imposing this calculation up in cfg80211. Thank you, Ashok > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
