On 12 June 2012 17:09, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Tue, 2012-06-12 at 13:40 +0300, Eyal Shapira wrote: > > Some Netgear APs like WNAP210 have a quirk behavior when > > configured for WEP Shared. They send an auth response with algo > > SHARED and status code NOT_SUPPORTED_AUTH_ALG (13) when being > > sent a request made with auth algo OPEN. Enable such response to > > propagate to userspace instead of discarding it so wpa_s can > > reattempt to auth with SHARED. > > Does cfg80211 need to handle this? How does wpa_s even handle it? wpa_s has the following code in wpa_supplicant/sme.c/sme_event_auth() to automatically "escalate" in the auth algorithms it tries (from OPEN to SHARED to LEAP) : switch (data->auth.auth_type) { case WLAN_AUTH_OPEN: wpa_s->current_ssid->auth_alg = WPA_AUTH_ALG_SHARED; wpa_dbg(wpa_s, MSG_DEBUG, "SME: Trying SHARED auth"); wpa_supplicant_associate(wpa_s, wpa_s->current_bss, wpa_s->current_ssid); return; case WLAN_AUTH_SHARED_KEY: wpa_s->current_ssid->auth_alg = WPA_AUTH_ALG_LEAP; wpa_dbg(wpa_s, MSG_DEBUG, "SME: Trying LEAP auth"); wpa_supplicant_associate(wpa_s, wpa_s->current_bss, wpa_s->current_ssid); return; I have a patch for that code in wpa_s as well which attempts SHARED in case we sent OPEN and got the NOT_SUPPORTED_AUTH_ALG response on SHARED. I first wanted to see that the kernel patch which allows the response to go through is accepted. You're right of course that I also need to take care of cfg80211 when using its SME. I'll send an additional patch for that. > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html