On 06/10/2012 06:54 PM, Rafał Miłecki wrote: > 2012/6/6 Florian Fainelli <florian@xxxxxxxxxxx>: >> Hi Hauke, >> >> On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >>> The SoCs do not need any special handling in bcma_pmu_pll_init(), >>> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >>> bcma_pmu_workarounds. This patches suppresses some warnings in the log. >> >> This does not look like it scales very good, how about you turn the pr_err() >> into a pr_debug() so that developpers porting bcma on a new chip need to turn >> on the appropriate debug knobs to get the message? > > debug sounds fine for me > Hi Rafał, bcma_pmu_swreg_init() and bcma_pmu_pll_init() are doing nothing should they get removed? In the current version of the patch I also removed the chip ids of the PCIe based cards from the switch case statement if they just ended in a break, is that ok with you? Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
