Search Linux Wireless

Re: [PATCH 1/2] mac80211: Keep tx rate averages for mesh peers for better metric calculation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-06-08 at 13:31 -0700, Jason Abele wrote:
> From: Javier Cardona <javier@xxxxxxxxxxx>
> 
> The mesh metric is computed every time it was requested by the path
> selection framework.  At that time only the last_tx_rate was taken into
> account when computing the metric.  This last frame may not reflect the
> average data rate that was possible ver that peer link (it could be a
> management frame, a rate control probe, or other outlier).
> 
> This patch maintains an average tx rate for each peer link which is used
> in metric calculation.

I don't think this makes a lot of sense, the TX rate is supposed to be
the "best rate" that the rate control algorithm decided on, so using
EWMA to weigh the bitrate seems a bit counter-productive.


> +++ b/net/mac80211/sta_info.h
> @@ -330,6 +330,7 @@ struct sta_info {
>  	unsigned long tx_retry_failed, tx_retry_count;
>  	/* moving percentage of failed MSDUs */
>  	unsigned int fail_avg;
> +	struct ewma avg_rate;

and in any case this is missing kernel-doc

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux