Search Linux Wireless

Re: [PATCH v2 2/4] mac80211: implement the proactive PREQ generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-06-07 at 12:39 +0800, Chun-Yeow Yeoh wrote:

> + * @IEEE80211_NO_ROOT: the mesh STA is not a root mesh STA (default)
> + * @IEEE80211_PROACTIVE_PREQ_NO_PREP: the mesh STA is a root mesh STA
> + * supports the proactive PREQ with proactive PREP subfield set to 0

please indent to make it readable

>  	mesh_path_tx_root_frame(sdata);
> +	interval = (ifmsh->mshcfg.dot11MeshHWMPRootMode ==
> +	    IEEE80211_PROACTIVE_RANN) ? ifmsh->mshcfg.dot11MeshHWMPRannInterval
> +	    : ifmsh->mshcfg.dot11MeshHWMProotInterval;

that's a horrible way to write this, I suppose an if statement could
actually be readable :-)

> +++ b/net/mac80211/mesh_hwmp.c
> @@ -33,9 +33,11 @@
>  /* Reply and forward */
>  #define MP_F_RF	0x2
>  /* Unknown Sequence Number */
> -#define MP_F_USN    0x01
> +#define MP_F_USN    0x04
>  /* Reason code Present */
>  #define MP_F_RCODE  0x02
> +/* Proactive PREQ with PREP */
> +#define PREQ_F_PREP 0x04

Should all of this really be here rather than in ieee80211.h?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux