On 06/06/2012 12:24 PM, Arend van Spriel wrote:
> On 06/06/2012 01:07 AM, Hauke Mehrtens wrote:
>> The xmtfifo_sz array contains the queue sizes for the different chip
>> revs. This array missed the sizes for the core rev 17 and 28. This
>
> Should probably use core revs instead of chip revs and I think we are
> talking about the 80211 core rev here.
Yes I will change this comment.
Are there any devices with the same phy type using different fifo sizes?
If this is not the case I think it is better to do this based on the phy
type.
>
>> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> @@ -268,7 +268,7 @@ struct brcms_c_bit_desc {
>> */
>>
>> /* Starting corerev for the fifo size table */
>> -#define XMTFIFOTBL_STARTREV 20
>> +#define XMTFIFOTBL_STARTREV 10
>
> Why not start the table at rev 17? I do not expect any lower revs to get
> brcmsmac support.
The 10 is a random number <=17. ;-)
I will change this to 17 then, makes sense.
>
> Gr. AvS
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
